"for many a ..." is a older style of saying things. It isn't used much in normal conversation. You would just say "for many years"
"the duties of an attorney are varied and many" - The normal way would be "an attorney has many various duties". Sometimes for style, we don't like to stack adjectives, so you can change the sentence order to achieve a different style. I think this is just a style choice.
|